----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55559/#review161795 -----------------------------------------------------------
common/src/main/java/org/apache/atlas/repository/Constants.java (line 59) <https://reviews.apache.org/r/55559/#comment233114> prefix "type." works only for types - like entity-def, trait-def. For instances, it should be the name of the type in which the attribute is defined. In this case, attributes name/description/owner are defined in type Asset - so the property names should be "Asset.name", "Asset.description", "Asset.owner". intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeaderWithAssociations.java (line 39) <https://reviews.apache.org/r/55559/#comment233102> Add Json annotations, similar to the ones in AtlasEntityHeader.java intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeaderWithAssociations.java (line 82) <https://reviews.apache.org/r/55559/#comment233101> classificationNames could be null. Update to handle this case. - Madhan Neethiraj On Jan. 16, 2017, 9:24 a.m., Vimal Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55559/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2017, 9:24 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1460 > https://issues.apache.org/jira/browse/ATLAS-1460 > > > Repository: atlas > > > Description > ------- > > DSL and FullText Search results don't contain attributes specific to an > entity like name, description, owner and list of associated traits > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java bcdf08c > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java > c4c0063 > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeaderWithAssociations.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > be9fed2 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java > a576dd0 > > Diff: https://reviews.apache.org/r/55559/diff/ > > > Testing > ------- > > No new test failures are introduced. > > > Thanks, > > Vimal Sharma > >
