----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55759/#review162436 -----------------------------------------------------------
dashboardv2/public/js/main.js (line 177) <https://reviews.apache.org/r/55759/#comment233758> "atlas.feature.taxonomy.enable" ==> "atlas.entity.create.allowed" dashboardv2/public/js/main.js (line 180) <https://reviews.apache.org/r/55759/#comment233759> "atlas.feature.taxonomy.enable" ==> "atlas.entity.update.allowed" webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java (line 197) <https://reviews.apache.org/r/55759/#comment233760> Since the method takes resourceType as argument, remove "Entity" from the method name: rename "isEntityAccessAllowed" ==> "isAccessAllowed" - Madhan Neethiraj On Jan. 20, 2017, 12:25 p.m., Kalyani Kashikar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55759/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2017, 12:25 p.m.) > > > Review request for atlas, keval bhatt and Madhan Neethiraj. > > > Bugs: ATLAS-1489 > https://issues.apache.org/jira/browse/ATLAS-1489 > > > Repository: atlas > > > Description > ------- > > # This patch is dependent on ATLAS-1437.patch > UI to show create / edit entity button based on permission of the loggedin > user. The attribute atlas.entity.update.allowed & atlas.entity.create.allowed > are set with flag true/false in response json. > > This patch also include change for v2/search api to set resourceType in > getAtlasResourceType method. > > > Diffs > ----- > > > authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java > 9f33115 > dashboardv2/public/js/main.js fe08754 > dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html > e47b0c2 > dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html 8d7f874 > dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js 2b43b59 > dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 8da3b00 > dashboardv2/public/js/views/entity/CreateEntityLayoutView.js c98ea18 > dashboardv2/public/js/views/search/SearchLayoutView.js 38bf6b5 > dashboardv2/public/js/views/search/SearchResultLayoutView.js 35a1152 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 02d7488 > > Diff: https://reviews.apache.org/r/55759/diff/ > > > Testing > ------- > > Changed permission in policy-store and verified the UI with create and edit > button. > > Verified response for session api from curl commands. > > * curl -kv -u admin:admin http://localhost:21000/api/atlas/admin/session > > {"atlas.rest-csrf.enabled":true,"atlas.rest-csrf.browser-useragents-regex":"^Mozilla.*,^Opera.*,^Chrome","atlas.rest-csrf.methods-to-ignore":"GET,OPTIONS,HEAD,TRACE","atlas.rest-csrf.custom-header":"X-XSRF-HEADER","atlas.feature.taxonomy.enable":false,"atlas.entity.update.allowed":true,"atlas.entity.create.allowed":true,"userName":"admin","groups":["ADMIN"]} > > * curl -kv -u rangertagsync:rangertagsync > http://localhost:21000/api/atlas/admin/session > > > {"atlas.rest-csrf.enabled":true,"atlas.rest-csrf.browser-useragents-regex":"^Mozilla.*,^Opera.*,^Chrome","atlas.rest-csrf.methods-to-ignore":"GET,OPTIONS,HEAD,TRACE","atlas.rest-csrf.custom-header":"X-XSRF-HEADER","atlas.feature.taxonomy.enable":false,"atlas.entity.update.allowed":false,"atlas.entity.create.allowed":false,"userName":"rangertagsync","groups":["RANGER_TAG_SYNC"]} > > > Thanks, > > Kalyani Kashikar > >
