----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55497/#review162440 -----------------------------------------------------------
Ship it! DSL search results page is fixed with this page. It shows the deleted status correctly; and also does not allow changes to tag. I will commit this patch. Please look into the following issues, which should be addressed in a subsequent patch: - full-text search results page does not show deleted status and allows changes to tag - tag search results page does not show deleted status and allows changes to tag - Madhan Neethiraj On Jan. 20, 2017, 11:49 a.m., Kalyani Kashikar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55497/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2017, 11:49 a.m.) > > > Review request for atlas, keval bhatt and Madhan Neethiraj. > > > Bugs: ATLAS-1437 > https://issues.apache.org/jira/browse/ATLAS-1437 > > > Repository: atlas > > > Description > ------- > > This patch consist changes for showing deleted entities based on v2 api > response. > > > Diffs > ----- > > dashboardv2/public/css/scss/main.scss f60e547 > dashboardv2/public/js/templates/business_catalog/AddTermView_tmpl.html > e784e6a > dashboardv2/public/js/templates/business_catalog/BusinessCatalogHeader.html > 7ff7106 > dashboardv2/public/js/templates/entity/CreateEntityLayoutView_tmpl.html > 01f2aa0 > dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html 6a2e81c > dashboardv2/public/js/templates/site/header.html 623d802 > dashboardv2/public/js/templates/tag/TagDetailTableLayoutView_tmpl.html > 4be7cc2 > dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 668b09d > dashboardv2/public/js/utils/CommonViewFunction.js ac14dfe > dashboardv2/public/js/utils/Globals.js fb95bc6 > dashboardv2/public/js/utils/Messages.js 6776903 > dashboardv2/public/js/utils/TableLayout.js fb1ad9f > dashboardv2/public/js/views/audit/AuditTableLayoutView.js b8b65e2 > dashboardv2/public/js/views/business_catalog/AddTermToEntityLayoutView.js > fddaf09 > dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js > 75ed98c > dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 8da3b00 > dashboardv2/public/js/views/search/SearchResultLayoutView.js 35a1152 > dashboardv2/public/js/views/tag/TagDetailLayoutView.js e9e1ab4 > dashboardv2/public/js/views/tag/TagLayoutView.js 0ac3745 > dashboardv2/public/js/views/tag/addTagModalView.js 649cad5 > > Diff: https://reviews.apache.org/r/55497/diff/ > > > Testing > ------- > > Following scenarios are tested: > > * Deleted entites shows in entity detail page. > * Assign restriction to add tag on deleted entity. > > > Thanks, > > Kalyani Kashikar > >
