----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55878/#review162835 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Jan. 24, 2017, 1:08 p.m., keval bhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55878/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 1:08 p.m.) > > > Review request for atlas, Madhan Neethiraj, Suma Shivaprasad, and Vimal > Sharma. > > > Bugs: ATLAS-1486 > https://issues.apache.org/jira/browse/ATLAS-1486 > > > Repository: atlas > > > Description > ------- > > UI to handle error according to errorMessage attribute from server reponse > object > > > Diffs > ----- > > dashboardv2/public/js/collection/BaseCollection.js 1f3faba > dashboardv2/public/js/collection/VCatalogList.js a631de1 > dashboardv2/public/js/collection/VCommonList.js 87091ca > dashboardv2/public/js/collection/VEntityList.js 99b0f3b > dashboardv2/public/js/collection/VLineageList.js a2656df > dashboardv2/public/js/collection/VSchemaList.js 18ffeda > dashboardv2/public/js/collection/VSearchList.js 3b02f05 > dashboardv2/public/js/collection/VTagList.js 92c6436 > dashboardv2/public/js/models/BaseModel.js 27e0332 > dashboardv2/public/js/models/VCatalog.js 85160b7 > dashboardv2/public/js/models/VCommon.js 25462fe > dashboardv2/public/js/models/VEntity.js 2173534 > dashboardv2/public/js/models/VLineage.js d55bfeb > dashboardv2/public/js/models/VSchema.js f7f083c > dashboardv2/public/js/models/VSearch.js 906b96f > dashboardv2/public/js/models/VTag.js 73cf3c8 > dashboardv2/public/js/utils/CommonViewFunction.js 7d41c1c > dashboardv2/public/js/utils/Messages.js d6acc32 > dashboardv2/public/js/utils/Overrides.js 3945e9f > dashboardv2/public/js/utils/Utils.js 4e003d9 > > dashboardv2/public/js/views/business_catalog/BusinessCatalogDetailLayoutView.js > edf5dec > dashboardv2/public/js/views/business_catalog/TreeLayoutView.js 431a6e7 > dashboardv2/public/js/views/common/aboutAtlas.js 75b009c > dashboardv2/public/js/views/entity/CreateEntityLayoutView.js c98ea18 > dashboardv2/public/js/views/graph/LineageLayoutView.js c1d860a > dashboardv2/public/js/views/search/SearchResultLayoutView.js 8d0720e > dashboardv2/public/js/views/tag/CreateTagLayoutView.js 3179276 > dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js ac28c0f > dashboardv2/public/js/views/tag/TagLayoutView.js 9ed7ae9 > dashboardv2/public/js/views/tag/addTagModalView.js 9c82d5c > > Diff: https://reviews.apache.org/r/55878/diff/ > > > Testing > ------- > > Tested following scenarios. > > * Created a tag with special character returns error and UI showing server > side error message. > * Unauthorized API message showing correctly. > * Added same attribute to tag and UI showing server side error message. > * Assign same tag to the entity and UI showing server side error message. > * Search API inavild query message. > > > *server side authorization error msg should be consistent for error handling. > (this needs to be handled in another jira) > > > Thanks, > > keval bhatt > >
