----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56105/#review163642 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java (line 53) <https://reviews.apache.org/r/56105/#comment235122> I suggest that it would be more flexible to be able to specify any attribute, not just the unique ones. For example if you have a name field on an entity, it may not be unique but it would be very useful. intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java (line 553) <https://reviews.apache.org/r/56105/#comment235126> I am wondering what happens if you specify an attribute that has an entity as its type, if the target entity has an attribute pointing back to our entity - wont this loop. I think we need to restrict the attribute type in the objectid to numbers or strings. I like the idea of a list of attributes. - David Radley On Jan. 31, 2017, 1:08 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56105/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2017, 1:08 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1506 > https://issues.apache.org/jira/browse/ATLAS-1506 > > > Repository: atlas > > > Description > ------- > > Attribute uniqueAttribues is now added to AtlasObjectId. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java > 4896e9d > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java a25f3f6 > intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java 7d55233 > > Diff: https://reviews.apache.org/r/56105/diff/ > > > Testing > ------- > > - updated unit tests to cover the changes to AtlasObjectId > > > Thanks, > > Madhan Neethiraj > >
