----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56126/#review163671 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexInfo.java (line 29) <https://reviews.apache.org/r/56126/#comment235147> Any particular reason behind the trailing _ ? repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexInfo.java (line 66) <https://reviews.apache.org/r/56126/#comment235144> Objects.hash instead of this. repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexInfo.java (line 75) <https://reviews.apache.org/r/56126/#comment235145> Objects.equals instead of this. - Apoorv Naik On Jan. 31, 2017, 3:43 p.m., Jeff Hagelberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56126/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2017, 3:43 p.m.) > > > Review request for atlas and David Kantor. > > > Bugs: ATLAS-1510 > https://issues.apache.org/jira/browse/ATLAS-1510 > > > Repository: atlas > > > Description > ------- > > These changes optimize GraphBackedTypeStore.store() so that it does all of > the required vertex lookup up front, using one query. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > ce8d4c75610a1337d72134bf245c72e375ad4984 > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java > c1c2a94e4367d4c4963a6d2807b1fe1d818102f7 > > repository/src/main/java/org/apache/atlas/repository/typestore/TypePersistenceVisitor.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexFinder.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexInfo.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/typestore/TypeVisitor.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java > 6b83aa3222c15ebad92399a6668ee5a802b10802 > > repository/src/test/java/org/apache/atlas/util/CompiledQueryCacheKeyTest.java > c926f4d7d793ef095b20853277f3ba979483e039 > > Diff: https://reviews.apache.org/r/56126/diff/ > > > Testing > ------- > > Ran entire Atlas build, no regressions found. > > > Thanks, > > Jeff Hagelberg > >
