----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56119/#review163700 -----------------------------------------------------------
Fix it, then Ship it! dashboardv2/public/js/main.js (line 185) <https://reviews.apache.org/r/56119/#comment235173> Consider renaming the property as below: "atlas.ui.edit.supported.entity-types" ==> "atlas.ui.editable.entity.types" dashboardv2/public/js/main.js (line 190) <https://reviews.apache.org/r/56119/#comment235172> If the list has only one entry, UI does not enable entity create/edit. Please review the following and update: "entityTypeList.length > 1" ==> "entityTypeList.length > 0" - Madhan Neethiraj On Jan. 31, 2017, 10:27 a.m., Kalyani Kashikar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56119/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2017, 10:27 a.m.) > > > Review request for atlas, keval bhatt and Madhan Neethiraj. > > > Bugs: ATLAS-1485 and ATLAS-1502 > https://issues.apache.org/jira/browse/ATLAS-1485 > https://issues.apache.org/jira/browse/ATLAS-1502 > > > Repository: atlas > > > Description > ------- > > This patch includes changes to configure list of entity type via > configuration in atlas-application properties > > atlas.ui.edit.supported.entity-types="type-1,type-2,type3" > > * If the configuration is set to an empty value (or not set): UI should not > support create/edit of any entity > * If the configuration is set to is set to '*', then UI should allow > create/edit of any type of entity > > Patch also includes - > > * Change the create entity button place (ATLAS-1485) > * After creating new entity redirect to detail page of that newly created > entity (ATLAS-1485) > > Handled following bugs in patch :- > > * FileSize attribute of hdfs_path and fs_path is long and its opens a > calendar when clicked. > * DSL query "array<string>" made when creating/editing an hive_table in UI > * Message changed From "entities selected have already been associated with > tag testTag, Do you want to associate the tag with other entities?" To "1 of > 2 entities selected have already been associated with testTag tag, Do you > want to associate the tag with other entities ?" > > > Diffs > ----- > > dashboardv2/public/css/scss/tag.scss 1f9561d > dashboardv2/public/js/main.js 2ddf1aa > dashboardv2/public/js/router/Router.js fa4a08a > dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html > 1de3608 > dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html 7301ebc > dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html > 32a0083 > dashboardv2/public/js/utils/Overrides.js d6d9b6c > dashboardv2/public/js/views/audit/AuditTableLayoutView.js dd4adda > dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js 2b43b59 > dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js c959229 > dashboardv2/public/js/views/entity/CreateEntityLayoutView.js 9f4e1d7 > dashboardv2/public/js/views/search/SearchDetailLayoutView.js 0ed1c38 > dashboardv2/public/js/views/search/SearchLayoutView.js bdb71a6 > dashboardv2/public/js/views/search/SearchResultLayoutView.js cbfe08e > dashboardv2/public/js/views/tag/addTagModalView.js 7317a95 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 54c46a8 > > Diff: https://reviews.apache.org/r/56119/diff/ > > > Testing > ------- > > Verified following scenario for ATLAS-1502: > > * If the configuration is set to an empty value (or not set): UI should not > support create/edit of any entity > * If the configuration is set to is set to "*", then UI should allow > create/edit of any type of entity. > * If the configuration is set to is set to "type-1,type-2,type3", then UI > should allow create/edit for "type-1,type-2,type3". > > Verified following scenario for ATLAS-1485: > > * Verified the create entity link. > * After entity creation, it redirects to entity detail page of that newly > created entity. > > Also Verified following scenario:- > > * Validation for long data-type for create/edit entity. > * Unwated api call for "array<string>" has been handled. > > > Thanks, > > Kalyani Kashikar > >
