> On Feb. 1, 2017, 12:36 p.m., keval bhatt wrote: > > Ship It!
Tried Following usecase. * Created entity * search that created entity * lineage of that created entity * delete entity * created hive_table entity using UI * created hive_column entity using UI - keval ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56161/#review163804 ----------------------------------------------------------- On Feb. 1, 2017, 10:47 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56161/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2017, 10:47 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1513 > https://issues.apache.org/jira/browse/ATLAS-1513 > > > Repository: atlas > > > Description > ------- > > - updated AtlasEntityType to get foreignKey-references to the type > - moved mappedFromRef from AtlasStructType to AtlasEntityType (as it is not > applicable to structs) > - simplified use of AtlasAttribute, by adding few helper methods and removing > a constructor parameter > - fixed incorrect persistence of mappedFromRef/foreignKey constraints to > store; this was exposed in a recent change to hive-model.json > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > 2c00f54 > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > d06364c > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java b83a241 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java bac5800 > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java e4f1eea > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 4f2916c > intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java 5c72470 > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 4e15edd > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/ArrayVertexMapper.java > e63ea6e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java > 4f5b4f4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > 163ddef > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 34e02c6 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > c98d340 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphMutationContext.java > 89419d9 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/MapVertexMapper.java > efafcc9 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java > 22851ca > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/UniqAttrBasedEntityResolver.java > 2698504 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java 5e69262 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java > 8777510 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java ee1174a > > webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java > 8eacc73 > > Diff: https://reviews.apache.org/r/56161/diff/ > > > Testing > ------- > > - added unit tests > - performed sanity tests with Atlas web application, like: > - hive notification processing > - search > - lineage > - delete entities > > > Thanks, > > Madhan Neethiraj > >
