----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56206/#review164051 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java (line 68) <https://reviews.apache.org/r/56206/#comment235588> It might be confusing to have "id" as a member here: - information in "id" is already available in AtlasStruct.typeName and AtlasEntitiy.guid. Dealing with different value between these can be trouble and if possible should be avoided. - AtlasObjectId supports uniqueAttributeValues to identify an object. This may not be useful/relevant here. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java (line 133) <https://reviews.apache.org/r/56206/#comment235597> It might be useful to add isAssigned() and isUnAssigned() methods to AtlasObjectId(). The result can be computed once and cached. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java (line 134) <https://reviews.apache.org/r/56206/#comment235599> Consider sending ((AtlasObjectId)entity) to addUnresolvedIdReference() - to avoid the method creating an instance of AtlasObjectId. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/UniqAttrBasedEntityResolver.java (line 78) <https://reviews.apache.org/r/56206/#comment235601> should vertex.guid be used in AtlasObjectId created here? entityId.getGuid() might have unassigned/null value - given this is about using unique attributes to find the entity. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/UniqAttrBasedEntityResolver.java (line 144) <https://reviews.apache.org/r/56206/#comment235617> Instead of iterating on all attributes, it might be quicker to iterate on entityId.getUniqueAttributes(). - Madhan Neethiraj On Feb. 2, 2017, 9:37 a.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56206/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2017, 9:37 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1522 > https://issues.apache.org/jira/browse/ATLAS-1522 > > > Repository: atlas > > > Description > ------- > > Currently child(composite) entities are allowed as attribute values in create > or update APIs. Allowing this to have only AtlasObjectId would avoid cycles > in the entity structure > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 8d1bfa7 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 9494fe4 > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > c9b6e97 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java fcd483c > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 0756937 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > c42f95f > > repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscoveryContext.java > 2d748da > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java > 2848a20 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 1590aee > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > a989f76 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java > d02b5a1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/UniqAttrBasedEntityResolver.java > 76308a0 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > 31a619e > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java > bbfcc59 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > 7368c72 > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 5107767 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java aa209f9 > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java > cfe9909 > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java > ee36fdf > > Diff: https://reviews.apache.org/r/56206/diff/ > > > Testing > ------- > > > Thanks, > > Suma Shivaprasad > >
