----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56096/#review164370 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java (line 120) <https://reviews.apache.org/r/56096/#comment236055> Constructor injection over field injection. - Apoorv Naik On Jan. 30, 2017, 9:24 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56096/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2017, 9:24 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, > Suma Shivaprasad, and Vimal Sharma. > > > Bugs: ATLAS-1501 > https://issues.apache.org/jira/browse/ATLAS-1501 > > > Repository: atlas > > > Description > ------- > > UI uses schema API to render entity details page. Current API returns excess > information regarding table definition, column definition. Updating the > schema API to use v2 APIs and to return minimal information. > > > Diffs > ----- > > addons/models/patches/002-hive_column_table_add_options.json 2de90b3 > addons/models/patches/002-hive_column_table_add_schema_options.json > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntitySchema.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java > f8083de > > repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java > e3eb52a > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 2b4561d > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > b14531f > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > d5d8d9b > webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 87e37e3 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java ee1174a > > Diff: https://reviews.apache.org/r/56096/diff/ > > > Testing > ------- > > Ran unit tests > > > Thanks, > > Sarath Subramanian > >
