> On Feb. 7, 2017, 5:55 p.m., Vimal Sharma wrote: > > addons/models/0060-hbase_model.json, line 37 > > <https://reviews.apache.org/r/56380/diff/1/?file=1626416#file1626416line37> > > > > hbase_model.json is a placeholder for now, right? > > I suggest we file a JIRA to revise the HBase model later
Vimal - hbase_model.json defines HBase types (table/column_family/column), which allow creation of entity instances of these types - via API or UI. This would allow users to add classifications to these instances - enabling classification-based authorization via Ranger. > On Feb. 7, 2017, 5:55 p.m., Vimal Sharma wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java, line 150 > > <https://reviews.apache.org/r/56380/diff/1/?file=1626420#file1626420line150> > > > > Code in Line 115-125 and 127-137 is common. > > Please move it outside the if check Though currently all constraints are applicable for attributes of type 'entity', this need not be the case. Hence this seemingly duplicate code. These checks can be moved to a seprate method, to avoid code duplicate. I will address this in the next patch update. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56380/#review164492 ----------------------------------------------------------- On Feb. 7, 2017, 11:06 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56380/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 11:06 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1526 > https://issues.apache.org/jira/browse/ATLAS-1526 > > > Repository: atlas > > > Description > ------- > > constraints foreignKey/mappedFromRef introduced in v2 doesn't handle all use > cases of legacy flags isComposite/reverseAttributeName. Hence replace these > constrainsts with new constraints "owner" and "inverserRef(attribute=attr)" > > > Diffs > ----- > > addons/models/0030-hive_model.json 5ae16cf > addons/models/0060-hbase_model.json 5febbbc > addons/models/0080-storm_model.json 344227d > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > 2c00f54 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 761eef5 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java f444e93 > intg/src/test/java/org/apache/atlas/TestUtilsV2.java b4aa8aa > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 032dce0 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > d48c87e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > f507ae0 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java > 2e9e5e4 > webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 1559eb9 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java cecf636 > > Diff: https://reviews.apache.org/r/56380/diff/ > > > Testing > ------- > > updated unit tests and verified that existing unit tests pass > > > Thanks, > > Madhan Neethiraj > >
