> On Feb. 8, 2017, 8:14 p.m., Jeff Hagelberg wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java, > > line 423 > > <https://reviews.apache.org/r/56287/diff/2/?file=1627188#file1627188line423> > > > > Is it safe to remove this check? I'm not sure it is a safe to assume > > calling ITypedInstance.get(...) will always return something that is > > non-null.
This check is not needed as it has already been done above. This was pointed out by a code scan a while back and I had already applied this same change on the fork. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56287/#review164757 ----------------------------------------------------------- On Feb. 9, 2017, 1 a.m., David Kantor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56287/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 1 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-499 > https://issues.apache.org/jira/browse/ATLAS-499 > > > Repository: atlas > > > Description > ------- > > ATLAS-499 auto update of reverse references in V1 API > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java > d9c7feb19cc15c16518682e2211b5cfb025d04f5 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java > f18c308346034a475c65b7103988d542dd8b1796 > > repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java > PRE-CREATION > > typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java > 5c977c147a63106b810f8855f3e7905b4075e165 > > Diff: https://reviews.apache.org/r/56287/diff/ > > > Testing > ------- > > Ran all unit and integration tests with no regressions. > > > Thanks, > > David Kantor > >
