----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56471/#review164989 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java (line 44) <https://reviews.apache.org/r/56471/#comment236822> update*Def() should be gone as well. update*DefByName() is needed to support renaming of types. Currently there is no usecase for this; and given typename is used in various places like edge-labels, vertex-attribute - it may not be easy to support rename. I would suggest to remove these methods now. We can revisit if there is a need later. webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java (line 68) <https://reviews.apache.org/r/56471/#comment236825> Consider using typeRegistry for reads - it will be more efficient than reading from typeDefStore. - Madhan Neethiraj On Feb. 9, 2017, 5:03 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56471/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 5:03 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, Suma Shivaprasad, and Vimal Sharma. > > > Bugs: ATLAS-1534 > https://issues.apache.org/jira/browse/ATLAS-1534 > > > Repository: atlas > > > Description > ------- > > ATLAS-1534: TypesREST clean up for simpler REST interface > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java > 0ce811bf46c235b011a6bbcb37917887159ef171 > intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java > 95c5e6415f41d1dfd5c9aa49792826bb5a7d3cfc > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > 7bd8a839927deec3e744a0f9a620befbca903cc2 > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java > 1f7adf35ebc77cbb2e40afe660eb9abcfffb2b7c > > Diff: https://reviews.apache.org/r/56471/diff/ > > > Testing > ------- > > mvn clean install executes successfully with few consistent IT failures. > > > Thanks, > > Apoorv Naik > >
