----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56289/#review165740 -----------------------------------------------------------
catalog/pom.xml (line 42) <https://reviews.apache.org/r/56289/#comment237594> Rather than relying on activeByDefault, we should set lucene.version to 4.8.1 in the properties section so it is used in the build. It titan1 is being used, the profile will cause that value to be overridden. I think the titan0 profile can just be removed here. graphdb/graphdb-impls/pom.xml (line 41) <https://reviews.apache.org/r/56289/#comment237593> Please remove the trailing whitespace. graphdb/titan0/pom.xml (line 40) <https://reviews.apache.org/r/56289/#comment237597> Extra whitespace graphdb/titan1/pom.xml (line 40) <https://reviews.apache.org/r/56289/#comment237591> It might make senes to change this profile to be automatically activated when java 8 is being used (and perhaps rename it to java-8). This way, this project will automatically start being built normally and having its unit tests run if/when Atlas starts using Java 8 in its Jenkins environment. pom.xml (line 1291) <https://reviews.apache.org/r/56289/#comment237596> You need to add an exclude here for titan1 so that the titan1 implementation is not added to the classpath and bundled in the war when titan 0 is being used. Truncated output from mvn dependency:tree in repository: titan 0 - incorrect - dependencies on both titan1 and titan0 are active [INFO] +- org.apache.atlas:atlas-graphdb-impls:pom:0.8-incubating-SNAPSHOT:test [INFO] | +- org.apache.atlas:atlas-graphdb-titan1:jar:0.8-incubating-SNAPSHOT:test [INFO] | - org.apache.atlas:atlas-graphdb-titan0:jar:0.8-incubating-SNAPSHOT:test titan 1 - correct - only dependency on titan1 is active [INFO] +- org.apache.atlas:atlas-graphdb-impls:pom:0.8-incubating-SNAPSHOT:test [INFO] | - org.apache.atlas:atlas-graphdb-titan1:jar:0.8-incubating-SNAPSHOT:test - Jeff Hagelberg On Feb. 14, 2017, 8:38 p.m., Neeru Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56289/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2017, 8:38 p.m.) > > > Review request for atlas, David Kantor and Jeff Hagelberg. > > > Bugs: ATLAS-695 > https://issues.apache.org/jira/browse/ATLAS-695 > > > Repository: atlas > > > Description > ------- > > ATLAS-695 Add titan1 project in atlas > > > Diffs > ----- > > catalog/pom.xml 00e56dc6d01959f81a2d0884396837e261cb3ff0 > catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java > 6a2ba53ddfc740bf77baf319b458853bd33864ec > > catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java > 901a549a8945d7314373feac8b9a5fea1340a85d > graphdb/graphdb-impls/pom.xml 57b5137178dd179f86edb9a7af4f260b4b7d0ece > graphdb/pom.xml 2d303e4d5c29943ceef7883f3ad10a366d7f26aa > graphdb/titan0/pom.xml 9d88a72f60a3fa6969a94bf62f40d0192781c199 > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java > f1b38e1a801c37d07857df77c48a2fadf8fee62b > > graphdb/titan0/src/main/java/org/apache/atlas/utils/IteratorToIterableAdapter.java > ed7c2a71ed1f12470a0a19e475adb145282c1681 > graphdb/titan1/pom.xml PRE-CREATION > graphdb/titan1/readme.txt PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/GraphDbObjectFactory.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Edge.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Element.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphDatabase.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphIndex.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphManagement.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1PropertyKey.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Vertex.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/TitanObjectFactory.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasElementPropertyConfig.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONMode.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONTokens.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONUtility.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1GraphQuery.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigDecimalSerializer.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigIntegerSerializer.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/StringListSerializer.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/TypeCategorySerializer.java > PRE-CREATION > > graphdb/titan1/src/main/resources/META-INF/services/javax.script.ScriptEngineFactory > PRE-CREATION > > graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/AbstractGraphDatabaseTest.java > PRE-CREATION > > graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/GraphQueryTest.java > PRE-CREATION > > graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java > PRE-CREATION > > graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/TitanGraphProviderTest.java > PRE-CREATION > graphdb/titan1/src/test/resources/atlas-application.properties PRE-CREATION > pom.xml 834ecae05ac73b2c42b61d2b4115f052a3c45ea8 > > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java > ffda9849e9632bff6764aed70c76a2f50f493d0d > webapp/pom.xml 5dc74019810cf8cd5b59d256e69f602c561119a0 > > Diff: https://reviews.apache.org/r/56289/diff/ > > > Testing > ------- > > This review request contains titan 1 project and related changes. Titan 1 > project is disabled by default. It gets enabled when titan1 profile is > enabled. It requires Java 8. > > More changes may require to bring Atlas up with Titan1. This serves as > initial implementation to support Titan1. > > It was a team effort at IBM. Jeff Hagelberg has contributed in this project. > > > Thanks, > > Neeru Gupta > >
