> On Feb. 23, 2017, 7:14 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java, > > line 333 > > <https://reviews.apache.org/r/56860/diff/1/?file=1644998#file1644998line333> > > > > It might be useful to add a method in AtlasAttribute, to return reverse > > attribute's AtlasAttribute. This can be initialized in > > AtlasEntityType.resolveReferencesPhase2(). > > > > This will help avoid lookups during entity attribute updates.
Good idea, I have applied the suggested changes. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56860/#review166483 ----------------------------------------------------------- On Feb. 24, 2017, 2:25 p.m., David Kantor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56860/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2017, 2:25 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1552 > https://issues.apache.org/jira/browse/ATLAS-1552 > > > Repository: atlas > > > Description > ------- > > Automatic update of inverse references in V2 (V1?) code path. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java > 57ad1063eb0d225102a2b8b72232054f57b9c36b > intg/src/test/java/org/apache/atlas/TestUtilsV2.java > 84e17cb364fbf6d07b2211d85e336d8146fdb684 > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java > 2d71d4135025339cd072982efa1231575bf21035 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > 3f87e695b01a21f0cbd453f6de68269c5fe025aa > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > f1efe46404d71187c2691f9b795916ed6c26ef3e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 09f69dbe6f519d84ae8e223532fc5adaa411ed9b > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java > 555f0acc22c4bec67f1a2a4064acad66e939747a > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateHardDeleteV1Test.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateSoftDeleteV1Test.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateV1Test.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56860/diff/ > > > Testing > ------- > > Ran all unit and integration tests with no regressions. > > > Thanks, > > David Kantor > >
