> On Feb. 23, 2017, 9:14 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java, > > line 92 > > <https://reviews.apache.org/r/56969/diff/2/?file=1645358#file1645358line92> > > > > Whether to return a Referenceable or an Id should not depend on the > > presence of the entity in referredEntity. Referenceable should be returned > > only when the attribute is 'isOwnedRef=true'. In all other cases, an Id > > should be returned. > > > > It might be required to send AtlasAttribute as parameter to this > > method, to determine the value of isOwnedRef - from > > AtlasStructFormatConverter.fromV2toV1. > > > > Also, other 'if/else' blocks here (for v2Obj type Map and AtlasEntity) > > should be updated to handle this consistently.
not valid any more. - Sarath ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56969/#review166536 ----------------------------------------------------------- On Feb. 24, 2017, 3:08 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56969/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2017, 3:08 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, > Suma Shivaprasad, and Vimal Sharma. > > > Bugs: ATLAS-1564 > https://issues.apache.org/jira/browse/ATLAS-1564 > > > Repository: atlas > > > Description > ------- > > With the v2 implementation of EntityREST ready, we must start routing all v1 > entity CRUD calls to start using v2 APIs in EntityREST. > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/AtlasClient.java 13896ce > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ca3023a > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasFormatConverter.java > 9d0d7f4 > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java > e14fafb > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > 3a037cc > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > bbfc3e5 > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 5127f74 > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > e0fb66c > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > f59cd9d > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 92ea93e > webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java > 3fe8e11 > > Diff: https://reviews.apache.org/r/56969/diff/ > > > Testing > ------- > > mvn clean package - all tests passed. > > > Thanks, > > Sarath Subramanian > >
