----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57103/#review166962 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java (line 52) <https://reviews.apache.org/r/57103/#comment239061> Classes referenced by newly added import don't seem to be used. Please review and update. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java (line 128) <https://reviews.apache.org/r/57103/#comment239066> consider sending 'context' as parameter to addClassification(), so that mapClassification() can use this context (and not create a new context). repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java (line 192) <https://reviews.apache.org/r/57103/#comment239062> "entityType" ==> "classificationType" repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java (line 798) <https://reviews.apache.org/r/57103/#comment239064> Consider moving line #798 to outside this for() loop - @#792 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java (line 214) <https://reviews.apache.org/r/57103/#comment239071> "new AtlasEntitiesWithExtInfo()" - consider sending null, as this is not a mandatory parameter in lower level methods that map attribute values. - Madhan Neethiraj On Feb. 27, 2017, 8:41 p.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57103/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2017, 8:41 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1601 > https://issues.apache.org/jira/browse/ATLAS-1601 > > > Repository: atlas > > > Description > ------- > > Add support for classification store, REST API for addition, deletion and gets > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java d58c514 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > 6c372b3 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > c84f169 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 09f69db > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 3ba2190 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java > 23e825e > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java d1bef78 > > Diff: https://reviews.apache.org/r/57103/diff/ > > > Testing > ------- > > Tested through TestEntityREST > > > Thanks, > > Suma Shivaprasad > >
