----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57227/#review167638 -----------------------------------------------------------
Ship it! Ship It! - Suma Shivaprasad On March 2, 2017, 2:18 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57227/ > ----------------------------------------------------------- > > (Updated March 2, 2017, 2:18 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1614 > https://issues.apache.org/jira/browse/ATLAS-1614 > > > Repository: atlas > > > Description > ------- > > Updated v1->v2 conversion to perform attribute validation > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java edcef4b > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java > 287ce15 > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 77db167 > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > 45b35b3 > > > Diff: https://reviews.apache.org/r/57227/diff/2/ > > > Testing > ------- > > - verified that v1 partial update fails when an invalid attribute value is > provided (instead of assigning default value) > > > Thanks, > > Madhan Neethiraj > >
