> On March 2, 2017, 3:54 a.m., Suma Shivaprasad wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java > > Line 369 (original), 371 (patched) > > <https://reviews.apache.org/r/57230/diff/1/?file=1653213#file1653213line371> > > > > should we change this to BigDecimal?
Given the return type is BigInteger, and also the max value here would be max-long, I think use of BigDecimal wouldn't make a difference. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57230/#review167646 ----------------------------------------------------------- On March 2, 2017, 3:37 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57230/ > ----------------------------------------------------------- > > (Updated March 2, 2017, 3:37 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1613 > https://issues.apache.org/jira/browse/ATLAS-1613 > > > Repository: atlas > > > Description > ------- > > - fix for bigdecimal value handling to avoid casting to long > - fixed incorrect HTTP status code for an error > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ad362c > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 600ef8c > > > Diff: https://reviews.apache.org/r/57230/diff/1/ > > > Testing > ------- > > - verified that big decimal attributes values are stored as given in the > input (like 1.7976931348623157e+308), instead of trimming to nearest long > value). > > > Thanks, > > Madhan Neethiraj > >
