> On March 2, 2017, 7:38 a.m., Apoorv Naik wrote: > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > > Line 273 (original) > > <https://reviews.apache.org/r/57241/diff/1/?file=1653516#file1653516line273> > > > > How do we know that the exception was thrown ? Consider adding an > > assert in the catch block to ensure that exception was indeed caught.
this is not valid anymore, in v2 we dont expect timeout since multiple create calls is treated as update. > On March 2, 2017, 7:38 a.m., Apoorv Naik wrote: > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > > Lines 401 (patched) > > <https://reviews.apache.org/r/57241/diff/1/?file=1653516#file1653516line403> > > > > Sending time as long works, please check. when we route to v2 Apis request object is passed as string and v2 apis cannot handle date in string format. We need to fix this as separate jira. - Sarath ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57241/#review167678 ----------------------------------------------------------- On March 2, 2017, 3:03 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57241/ > ----------------------------------------------------------- > > (Updated March 2, 2017, 3:03 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1621 > https://issues.apache.org/jira/browse/ATLAS-1621 > > > Repository: atlas > > > Description > ------- > > Fix for the failed ITs: > Failed tests: > EntityJerseyResourceIT.testAddNullPropertyValue:423 Expected > AtlasServiceException > EntityJerseyResourceIT.testAddReferenceProperty:449->addProperty:467 » > AtlasService > EntityJerseyResourceIT.testEntityDeduping:264 » AtlasService Metadata > service ... > EntityJerseyResourceIT.testPartialUpdate:739 » AtlasService Metadata service > A... > EntityV2JerseyResourceIT.testAddNullPropertyValue:335->createHiveTable:443->createHiveTable:452 > expected object to not be null > EntityV2JerseyResourceIT.testEntityDeduping:197 » AtlasService Metadata > servic... > org.apache.atlas.web.resources.EntityV2JerseyResourceIT.testEntityInvalidValue(org.apache.atlas.web.resources.EntityV2JerseyResourceIT) > Run 1: PASS > Run 2: EntityV2JerseyResourceIT.testEntityInvalidValue:272 expected:<null> > but was:<AtlasEntityHeader{guid='d8cd8064-25cf-490d-aa88-5a93392677de', > status=ACTIVE, displayText=null, classificationNames=[],, > AtlasStruct{typeName='hive_db_v2', attributes=[name:LMPplE6apZ]}}> > EntityV2JerseyResourceIT.testSubmitEntity:103->createDBAndTable:437->createHiveTable:443->createHiveTable:452 > expected object to not be null > EntityV2JerseyResourceIT.testSubmitEntityWithBadDateFormat:296 expected > object to not be null > MetadataDiscoveryJerseyResourceIT.setUp:64->BaseResourceIT.createInstance:234 > » AtlasService > Tests run: 135, Failures: 10, Errors: 0, Skipped: 17 > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/AtlasClientV2.java af7dbbf > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > 61657a1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > a3d951d > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateV1Test.java > a198e61 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 6d902db > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 288ef82 > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java > 0c1ffd3 > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 0bcabb7 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > b37dbca > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java > e0e32a8 > > > Diff: https://reviews.apache.org/r/57241/diff/2/ > > > Testing > ------- > > mvn clean verify -pl webapp -DskipUTs - all ITs tests suceeded > mvn clean install (in progress) > > > Thanks, > > Sarath Subramanian > >
