[
https://issues.apache.org/jira/browse/ATLAS-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931281#comment-15931281
]
Ashutosh Mestry commented on ATLAS-1666:
----------------------------------------
Thanks [~nixonrodrigues]! Appreciate your help. Patch looks fine.
[~madhan.neethiraj] I have updated review item.
> Improve on Overly Broad Throws
> ------------------------------
>
> Key: ATLAS-1666
> URL: https://issues.apache.org/jira/browse/ATLAS-1666
> Project: Atlas
> Issue Type: Improvement
> Components: atlas-core
> Reporter: Ashutosh Mestry
> Assignee: Ashutosh Mestry
> Fix For: 0.9-incubating
>
> Attachments: ATLAS-1666.1.patch, ATLAS-1666.patch
>
>
> Methods in the following classes throws generic exception. This makes it hard
> for callers to effectively handle errors and recover. Although, this does not
> impact functionality. It would be valuable to improve on this.
> Below is a files that have this pattern:
> 1. _ActiveInstanceState.java_
> 2. _AbstractParam.java_
> 3. _QuickStart.java_
> 4. _SetupSteps.java_
> 5. _FalconHook.java_
> 6. _AtlasLdapAuthenticationProvider.java_
> 7. _FalconEventPublisher.java_
> 8. _AtlasADAuthenticationProvider.java_
> 9. _StormHook.java_
> 10. _FalconBridge.java_
> 11. _EmbeddedServer.java_
> 12. _StormTopologyUtil.java_
> 13. _SqoopHook.java_
> 14. _HiveHook.java_
> 15. _HiveMetaStoreBridge.java_
> General approach to refactoring would be define an error code in
> _AtlasErrorCode_ and throw _AtlasBaseException_.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
