----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58333/#review171657 -----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java Line 315 (original), 318 (patched) <https://reviews.apache.org/r/58333/#comment244652> Consider adding @DefaultValue("false") for 'createIfMissing' param. webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java Lines 335 (patched) <https://reviews.apache.org/r/58333/#comment244651> Instead of using exception to detect non-existing types, consider using: typeRegistry.isRegisteredType(typeName). if (typeRegistry.isRegisteredType(enumDef.getName())) { updateTypeDefs.getEnumDefs().add(enumDef); } else { createTypeDefs.getEnumDefs().add(enumDef); } - Madhan Neethiraj On April 11, 2017, 5:03 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58333/ > ----------------------------------------------------------- > > (Updated April 11, 2017, 5:03 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > Sarath Subramanian, and Suma Shivaprasad. > > > Repository: atlas > > > Description > ------- > > TypesREST to support creation in an update call > > > Diffs > ----- > > webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java > 424ca58ce0bdeb71a6ddc829f98f303988216c99 > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java > 5d846cf317ae46fa88ef7877baad129638e38e03 > > > Diff: https://reviews.apache.org/r/58333/diff/2/ > > > Testing > ------- > > mvn clean package executes successfully > > > Thanks, > > Apoorv Naik > >
