> On April 10, 2017, 10:06 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java > > Lines 252 (patched) > > <https://reviews.apache.org/r/58163/diff/1/?file=1684173#file1684173line252> > > > > - is it necessary to specify both attributeName and > > attributeQualifiedName? > > - since this class doesn't capture all search details (like typeName, > > classificatioName, search-text), consider renaming this to > > AtlasAttributeFilterParams
not valid anymore - added attribute search as part of basic search. > On April 10, 2017, 10:06 p.m., Madhan Neethiraj wrote: > > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java > > Lines 187 (patched) > > <https://reviews.apache.org/r/58163/diff/1/?file=1684176#file1684176line187> > > > > instead of a new REST endpoint '/attribute', consider enhancing > > '/basic' to support arguments 'attrName' and 'attrValue'. I have retained the REST end point - '/attribute' but changed it to point to basic search implementation. - Sarath ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58163/#review171518 ----------------------------------------------------------- On April 3, 2017, 3:26 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58163/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 3:26 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Suma Shivaprasad. > > > Bugs: ATLAS-1710 > https://issues.apache.org/jira/browse/ATLAS-1710 > > > Repository: atlas > > > Description > ------- > > Implement the entity-lookup API > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java > bf1c80e8 > > repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java > 1044aaa8 > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 571ce6ea > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 61f98475 > > > Diff: https://reviews.apache.org/r/58163/diff/1/ > > > Testing > ------- > > All UTs and ITs passed: > > mvn clean install > > > Thanks, > > Sarath Subramanian > >
