----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57758/#review171986 -----------------------------------------------------------
repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java Lines 256 (patched) <https://reviews.apache.org/r/57758/#comment245013> is this if() block necessary, given line #261 will fail if entity is null? repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java Lines 275 (patched) <https://reviews.apache.org/r/57758/#comment245014> Consider replacing this if() block with: Assert.assertNotNull(entity); repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java Lines 291 (patched) <https://reviews.apache.org/r/57758/#comment245015> Consider replacing this if() block with: Assert.assertNotNull(entity); repository/src/test/java/org/apache/atlas/repository/impexp/ZipSourceTest.java Lines 52 (patched) <https://reviews.apache.org/r/57758/#comment245016> is this if() block necessary, given line #57 will fail if creationOrder is null? repository/src/test/java/org/apache/atlas/repository/impexp/ZipSourceTest.java Lines 106 (patched) <https://reviews.apache.org/r/57758/#comment245017> Consider replacing this if() block with: Assert.assertNotNull(e); - Madhan Neethiraj On April 14, 2017, 2:14 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57758/ > ----------------------------------------------------------- > > (Updated April 14, 2017, 2:14 a.m.) > > > Review request for atlas, Madhan Neethiraj and Nixon Rodrigues. > > > Bugs: ATLAS-1735 > https://issues.apache.org/jira/browse/ATLAS-1735 > > > Repository: atlas > > > Description > ------- > > For Unit tests: > - Added _Assert.fail_ after _NULL_ check. > > For _AuthenticationUtils_: > - Added if clause. > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java > b5b00268 > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java > bac831b7 > > repository/src/test/java/org/apache/atlas/repository/impexp/ZipSourceTest.java > e124ffc4 > > > Diff: https://reviews.apache.org/r/57758/diff/1/ > > > Testing > ------- > > For Unit tests: Ran unit tests. > For AuthenticationUtil: Deployed and tested _quick_start.py_. > Compiled. > > > Thanks, > > Ashutosh Mestry > >
