> On April 21, 2017, 7:56 a.m., David Radley wrote: > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > > Line 148 (original), 148 (patched) > > <https://reviews.apache.org/r/58588/diff/1/?file=1695761#file1695761line149> > > > > I would expect the combination of the query and query params to fully > > specify the scope of a search; I would not expect a separate boolean on th > > API to be exposed. > > Can we fold this flag into the query params? > > I would expect the default search behaviour to pick up only active > > entities, then have a historical flag to pick up old entities. I realise > > this changes the default; do we think there would be much impact to > > changing this default? > > Sarath Subramanian wrote: > Yes, what you proposed is right. Default search behavior should not have > deleted entities unless specified. So we still expose the historical flag as > boolean flag in REST, to retrieve all deleted entities?
>> do we think there would be much impact to changing this default? For the REST API, I think it is important to keep the backward compatibility to avoid breaking of applications that use the API. Hence the default value excludeDeletedEntities=false in REST API. There is no such default value at this layer (*Service) though. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58588/#review172596 ----------------------------------------------------------- On April 20, 2017, 7:23 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58588/ > ----------------------------------------------------------- > > (Updated April 20, 2017, 7:23 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Suma Shivaprasad. > > > Bugs: ATLAS-1742 > https://issues.apache.org/jira/browse/ATLAS-1742 > > > Repository: atlas > > > Description > ------- > > Atlas UI needs to be enhanced to enable search on active entities in fulltext > and basic search. This JIRA addresses the backend changes needed to enable > this functionality. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java > 30d62a4b > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 07190dbf > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 836626b5 > > > Diff: https://reviews.apache.org/r/58588/diff/1/ > > > Testing > ------- > > testing in progress > > > Thanks, > > Sarath Subramanian > >
