[ 
https://issues.apache.org/jira/browse/ATLAS-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997909#comment-15997909
 ] 

Christopher Grote commented on ATLAS-1690:
------------------------------------------

While in general I agree with [~davidrad]'s prior suggestions that in general 
relationships should be bi-directional in nature, so am at first hesitant to 
think in terms of "from" and "to", nonetheless I think 
[~sarath.ku...@gmail.com] is raising a good point about the explicit 
directionality being potentially important for tag propagation.

To further describe the inherent bi-directionality, would it be worthwhile to 
capture a description within the "from" and "to" as well, e.g.

{code:javascript}
{
  "relationDef": {
    "name" : "CollectionToEntityRelation",
    "description" : "Entity Collection relationship",
    "from": {
      "types" : [ "Collection" ],
      "cardinality": "SINGLE",
      "name" : "group",
      "description": "Has entities"
    },
    "to": {
      "types" : ["entity"],
      "cardinality": "SET",
      "name": "member",
      "description": "Within collection"
    },
    "propagateTags": true,
    "relationType" : "association"
  }
}
{code}

(Though in this particular example, I would further assume that a particular 
entity could be in more than one collection, so not sure the cardinality is 
correct on the "from" side; though perhaps it's the relationType of 
"association" rather than "contains" that addresses this?)

What about "propagatesTags" being an enum rather than a simple boolean, e.g. 
"FROM-TO", "TO-FROM", "BI-DIRECTIONAL"; in case there are scenarios where it 
would make sense to apply the super-set of tags (from both sides of the 
relationship)?

> Introduce top level relationships
> ---------------------------------
>
>                 Key: ATLAS-1690
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1690
>             Project: Atlas
>          Issue Type: Improvement
>            Reporter: David Radley
>            Assignee: David Radley
>              Labels: VirtualDataConnector
>         Attachments: Atlas_RelationDef_Json_Structure_v1.pdf, Atlas 
> Relationships proposal v1.0.pdf, Atlas Relationships proposal v1.1.pdf, Atlas 
> Relationships proposal v1.2.pdf, Atlas Relationships proposal v1.3.pdf, Atlas 
> Relationships proposal v1.4.pdf, Atlas Relationships proposal v1.5.pdf, Atlas 
> Relationships proposal v1.6.pdf, Atlas Relationships proposal v1.7.pdf
>
>
> Introduce top level relationships including support for 
> -many to many relationships
> - relationship names including the name for both ends and the relationship.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to