I think Nixon has a good point. I think it’s possible to configure apache Jenkins instance to fail any builds that add new issues. Let’s follow up with a PMC or Infra to make necessary changes to the Jenkins build job.
On 5/15/17, 11:27 PM, "Nixon Rodrigues" <nixon.rodrig...@freestoneinfotech.com> wrote: >Jan, > >Appreciate your effort to improve Atlas code quality. > >I think we should keep a threshold limit for findbugs issue, if new code >introduced adds code issue and cross the limit it should fails the build. >Is this possible ? > >Nixon > >On Tue, May 16, 2017 at 1:47 AM, Jan Hentschel < >jan.hentsc...@ultratendency.com> wrote: > >> Hi, >> >> >> >> I filed ATLAS-1789 for fixing the Findbugs issues throughout the codebase. >> Currently these issues don’t let the build fail. Just want to start a >> discussion on whether to change the configuration to fail the build on >> Findbugs errors. Any opinions? >> >> >> >> Best, Jan >> >>
