-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59321/#review175182
-----------------------------------------------------------


Fix it, then Ship it!





repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
Lines 260 (patched)
<https://reviews.apache.org/r/59321/#comment248572>

    createDslLikeQueriesWithLimit() ==> createDslLikeQueries()


- Madhan Neethiraj


On May 17, 2017, 12:05 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59321/
> -----------------------------------------------------------
> 
> (Updated May 17, 2017, 12:05 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1807
>     https://issues.apache.org/jira/browse/ATLAS-1807
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Current DSL search doesn't support wildcard searches, this JIRA will 
> introduce a new operator in DSL for wildcard - "like"
> eg.
> hive_table where name like "employee*"
> hive_column where qualifiedName like "defa?lt*"
> hive_column where name like "loc*" and position=5 and qualifiedName like 
> "default.employee2*"
> 
> 
> Diffs
> -----
> 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java
>  807dd055 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
>  9f68c9a0 
>   
> repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java
>  ff5a58c9 
>   repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 
> 3a310a77 
>   repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 8d454e94 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  18573fc8 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java
>  db3a7c36 
> 
> 
> Diff: https://reviews.apache.org/r/59321/diff/3/
> 
> 
> Testing
> -------
> 
> Added UTs and ITs to test this feature.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Reply via email to