----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60014/#review177667 -----------------------------------------------------------
Ship it! Ship It! - Nixon Rodrigues On June 12, 2017, 6:21 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60014/ > ----------------------------------------------------------- > > (Updated June 12, 2017, 6:21 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > Sarath Subramanian, and Suma Shivaprasad. > > > Bugs: ATLAS-1872 > https://issues.apache.org/jira/browse/ATLAS-1872 > > > Repository: atlas > > > Description > ------- > > 1. In a kerberized environment Atlas fails to start as the LoginProcessor > doesn't perform login before bean creation > 2. HBaseAuditRepository should be default instead of NoopEntityAuditRepository > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java > 89ca7480 > > repository/src/main/java/org/apache/atlas/repository/audit/NoopEntityAuditRepository.java > 7c39ce9b > webapp/src/main/java/org/apache/atlas/web/listeners/LoginProcessor.java > e21656e7 > webapp/src/main/java/org/apache/atlas/web/setup/KerberosAwareListener.java > PRE-CREATION > webapp/src/main/webapp/WEB-INF/web.xml d2d08f5a > > > Diff: https://reviews.apache.org/r/60014/diff/1/ > > > Testing > ------- > > mvn clean package (success) > mvn clean install (partial success with known failures) > > Started Atlas manually and verified that the LoginProcessor.login in invoked > well before any bean creation. > > > Thanks, > > Apoorv Naik > >