----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60066/#review178033 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java Line 46 (original), 46 (patched) <https://reviews.apache.org/r/60066/#comment251805> TRAIT_NAME_REGEX may grow in size each time we decide to add a new language. We need to find the locale of the string and validate it against supported locales for Atlas. - Sarath Subramanian On June 14, 2017, 3:18 a.m., qinglin xia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60066/ > ----------------------------------------------------------- > > (Updated June 14, 2017, 3:18 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1865 > https://issues.apache.org/jira/browse/ATLAS-1865 > > > Repository: atlas > > > Description > ------- > > Fix ATLAS-1865 (https://issues.apache.org/jira/browse/ATLAS-1865), Atlas 0.9 > can not create trait/term in Chinese > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java > 89445048 > > > Diff: https://reviews.apache.org/r/60066/diff/2/ > > > Testing > ------- > > Create Term in Chinese > Create Trait in Chinese > > > Thanks, > > qinglin xia > >
