----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60159/#review178117 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Line 250 (original), 255 (patched) <https://reviews.apache.org/r/60159/#comment251925> Accidental change, will revert repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java Lines 114 (patched) <https://reviews.apache.org/r/60159/#comment251929> Can be changed to a HashSet too. repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java Lines 151 (patched) <https://reviews.apache.org/r/60159/#comment251928> No need of MapUtil check here as the map is already instantiated - Apoorv Naik On June 16, 2017, 6:05 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60159/ > ----------------------------------------------------------- > > (Updated June 16, 2017, 6:05 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Suma Shivaprasad. > > > Bugs: ATLAS-1880 > https://issues.apache.org/jira/browse/ATLAS-1880 > > > Repository: atlas > > > Description > ------- > > See JIRA > > > Sample Request structure > > ```json > { > "typeName": "hive_table", > "excludeDeletedEntities": false, > "limit": 25, > "offset": 0, > "entityFilters": { > "condition": "AND", > "criterion": [{ > "attributeName": "retention", > "operator": "=", > "attributeValue": "10" > }, { > "condition": "OR", > "criterion": [{ > "attributeName": "createTime", > "operator": ">", > "attributeValue": "1111111111" > }, { > "attributeName": "lastAccessTime", > "operator": "<=", > "attributeValue": "2222222222" > }] > }] > } > } > ``` > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/AtlasClientV2.java 61413428 > common/src/main/java/org/apache/atlas/repository/Constants.java ac022528 > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java > bd7b35e4 > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java > 5ad176b5 > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java > 9dc175b6 > intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java > 923a198b > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 128cdbf9 > repository/src/main/java/org/apache/atlas/discovery/GremlinSearchStep.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/discovery/SolrSearchStep.java > PRE-CREATION > repository/src/test/java/org/apache/atlas/TestModules.java 095af417 > > repository/src/test/java/org/apache/atlas/discovery/GremlinSearchStepTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java > 5d5b043e > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ea550211 > > > Diff: https://reviews.apache.org/r/60159/diff/1/ > > > Testing > ------- > > In progress > > 1. Tested Json marshalling and unmarshalling via REST > > > Thanks, > > Apoorv Naik > >
