> On June 20, 2017, 7:33 a.m., Sarath Subramanian wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java > > Lines 287 (patched) > > <https://reviews.apache.org/r/60204/diff/1/?file=1753523#file1753523line287> > > > > do we need similar validation in line 281 and 283, also 333 and 335?
My thinking is that by the time the control comes to this line, it has already undergone validation. Which means that it is valid Double/Float type. > On June 20, 2017, 7:33 a.m., Sarath Subramanian wrote: > > intg/src/test/java/org/apache/atlas/type/AtlasBuiltInTypesTest.java > > Lines 44 (patched) > > <https://reviews.apache.org/r/60204/diff/1/?file=1753524#file1753524line44> > > > > consider adding test case for 'v' to be of type: Float/Number for line > > 44 and Double/Number for line 49. TestAtlasBuiltFloatType already exists. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60204/#review178352 ----------------------------------------------------------- On June 19, 2017, 7:41 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60204/ > ----------------------------------------------------------- > > (Updated June 19, 2017, 7:41 p.m.) > > > Review request for atlas, Madhan Neethiraj and Sarath Subramanian. > > > Bugs: ATLAS-1876 > https://issues.apache.org/jira/browse/ATLAS-1876 > > > Repository: atlas > > > Description > ------- > > **Background** > Refer to ATLAS-1876 for details. Please see the modified steps in comments > section. > > **Root Cause** > _AtlasBuiltInTypes_ do not validate the incoming types using the range check > for the primitive types. This causes out of range _float_ and _double_ values > to be passed as valid even when they are holding _Infinity_. > > While the attribute value assignment goes through within the code, subsequent > operations fail as the correct values are not present in the database. > > **Fix** > Range check added for _float_ and _double_. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java f08a6015 > intg/src/test/java/org/apache/atlas/type/AtlasBuiltInTypesTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60204/diff/1/ > > > Testing > ------- > > **Unit tests** > - New unit tests added for _AtlasFloatType_ and _AtlasDoubleType_. > > **Functional tests** > - Validation verified by following steps mentioned in JIRA. Validation error > is returned instead of successful operation. > > > Thanks, > > Ashutosh Mestry > >
