----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60213/#review178403 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java Lines 137 (patched) <https://reviews.apache.org/r/60213/#comment252335> Shouldn't both ends be non-null? The validation here allows both ends be null. What would be the usecase for this? - Madhan Neethiraj On June 20, 2017, 3:19 p.m., David Radley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60213/ > ----------------------------------------------------------- > > (Updated June 20, 2017, 3:19 p.m.) > > > Review request for atlas, Madhan Neethiraj and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > addressing Coverity Scan for Jira ATLAS-1887 > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java > e8971a80e38b1ee2337cebc696ccb23bf5cd3323 > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > 296c06c260e471f6e2effde14ee905eb305cbe74 > intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java > 7a4e9fd500456a326d4d52732639d69ff9be510f > > > Diff: https://reviews.apache.org/r/60213/diff/3/ > > > Testing > ------- > > Run junits > Created a relationshipDef and then did a get on it. > > > Thanks, > > David Radley > >
