Hi Zhang Li, Different versions of Spark have different set of test suites, if we use @sparkver to combine all the different tests across different versions of Spark together? I do not think it is worth doing that: finding the common and different tests between each version of spark. And it might make add tests for different Spark version hard: contributors need to coordinate even if they are adding tests for different version.
If my understand it correctly, @sparkver is good for very small API differences between different Spark versions. For spark tests differences I think it is not small. On 2025/12/17 12:58:14 Zhang Li wrote: > +1 > i'd like to see someone working on improving the correctness of the project. > one suggestion: as we already have spark-version-annotation-macros to > distinguish different spark versions. it is better to have just one testing > module, and use the `@sparkver` annotation to activate/deactivate specified > spark versions. > > James <[email protected]> 于2025年12月17日周三 00:05写道： > > > Hi, everyone I'd like to start a discussion about AIP-2: Enhance Auron’s > > Correctness Testing [1]. Looking forward to your feedback. > > > > [1]. > > > > https://docs.google.com/document/d/1v8wMyLZXuA7tmDSJysAo8CRqWX36SWR5ZgjyOMSfm94/edit?tab=t.0 > > >
