I reverse my vote to -1 and am closing the vote as failed.

Turns out i had some old debs in my dist/ dir, and the test script picked
those up.  After clearing those, i encounter the same issue.

Here is the culprit:

$ ag -i THERMOS_EXECUTOR_RESOURCES
specs/debian/aurora-scheduler.startup.sh
37:  -thermos_executor_resources="$THERMOS_EXECUTOR_RESOURCES" \

specs/debian/aurora-scheduler.upstart
34:      -thermos_executor_resources="$THERMOS_EXECUTOR_RESOURCES" \

specs/debian/aurora-scheduler.init
75:        -thermos_executor_resources="$THERMOS_EXECUTOR_RESOURCES" \

specs/debian/aurora-scheduler.default
65:THERMOS_EXECUTOR_RESOURCES=""

thermos_executor_resources is passed an empty string.  Here is the option
definition:

@Parameter(names = "-thermos_executor_resources",
> description = "A comma separated list of additional resources to copy
> into the sandbox."
> + "Note: if thermos_executor_path is not the thermos_executor.pex file
> itself, "
> + "this must include it.")
> public List<String> thermosExecutorResources = ImmutableList.of();


We expect this to become an empty list, however the parser emits a list of
size one, containing an empty string.  I've filed AURORA-1962
<https://issues.apache.org/jira/browse/AURORA-1962> for the issue.


On Wed, Dec 13, 2017 at 3:31 PM, Renan DelValle <renanidelva...@gmail.com>
wrote:

> I'm running into the same issues as Stephan. I tried with Trusty, Xenial,
> and Jessie. Same issue with all.
>
> Somehow a Mesos fetcher entry with a URI value of '' gets injected into the
> task protobuf.
>
> This is the command I ran for Trusty:
> ./test/test-artifact.sh test/deb/ubuntu-trusty/
> /repo/artifacts/aurora-ubuntu-trusty/dist
>
> Oddly enough, we have deployed 0.19.0 packages for trusty without any issue
> on at least two of our test clusters so it may have to do with our
> artifacts tests?
>
> I tried upgrading the trusty box to Mesos 1.2.2 and the problem persisted.
>
> -Renan
>
> On Wed, Dec 13, 2017 at 9:28 AM, Mohit Jaggi <mohit.ja...@uber.com> wrote:
>
> > +1
> >
> > On Wed, Dec 13, 2017 at 9:03 AM, Bill Farner <wfar...@apache.org> wrote:
> >
> > > We would need at least 2 more binding votes to complete this release.
> Do
> > > folks need more time?
> > >
> > > On Tue, Dec 12, 2017 at 2:49 PM, thinker0 <think...@gmail.com> wrote:
> > >
> > > > +1, we 0.19.0 small production tested
> > > > 2017년 12월 13일 (수) 04:05, Mohit Jaggi <mohit.ja...@uber.com>님이 작성:
> > > >
> > > > > +0, we don't use the packages. If you just need someone to test and
> > > > verify,
> > > > > I can do that. Let me know.
> > > > >
> > > > > On Tue, Dec 12, 2017 at 9:53 AM, Bill Farner <wfar...@apache.org>
> > > wrote:
> > > > >
> > > > > > Friendly reminder that the vote is due to close tomorrow!
> > > > > >
> > > > > > Stephan - is the issue you described reproducible?  Did i run the
> > > same
> > > > > test
> > > > > > command(s) as you?
> > > > > >
> > > > > > On Sun, Dec 10, 2017 at 8:32 PM, Bill Farner <wfar...@apache.org
> >
> > > > wrote:
> > > > > >
> > > > > > > +1 from me, as the test script passes for all artifacts
> > > > > > >
> > > > > > > I did not have time to run them prior to opening the vote; but
> i
> > do
> > > > not
> > > > > > > encounter the failure you did:
> > > > > > >
> > > > > > > $ ./test/test-artifact.sh test/deb/debian-jessie/
> > > > > > > /repo/artifacts/aurora-debian-jessie/dist
> > > > > > > ....
> > > > > > > OK (all tests passed)
> > > > > > > Connection to 127.0.0.1 closed.
> > > > > > > ==> aurora_jessie: Forcing shutdown of VM...
> > > > > > >
> > > > > > > the branch is missing
> > > > > > >
> > > > > > >
> > > > > > > That i cannot speak for, unfortunately.
> > > > > > >
> > > > > > > For those who have yet to try out the builds, here are the test
> > > > > commands
> > > > > > i
> > > > > > > ran.  You can reproduce these by first downloading the
> artifacts
> > > (in
> > > > my
> > > > > > > case, they were under artifacts/*)
> > > > > > >
> > > > > > > ./test/test-artifact.sh test/deb/debian-jessie/
> > > > > > > /repo/artifacts/aurora-debian-jessie/dist/
> > > > > > > ./test/test-artifact.sh test/deb/ubuntu-trusty/
> > > > > > > /repo/artifacts/aurora-ubuntu-trusty/dist/
> > > > > > > ./test/test-artifact.sh test/deb/ubuntu-xenial/
> > > > > > > /repo/artifacts/aurora-ubuntu-xenial/dist/
> > > > > > > ./test/test-artifact.sh test/rpm/centos-7/
> > > > > /repo/artifacts/aurora-centos-
> > > > > > > 7/dist/rpmbuild/RPMS/x86_64
> > > > > > >
> > > > > > > Each command took about 5 mins to run in my case.
> > > > > > >
> > > > > > > A belated thanks to Stephan for adding the test script!
> > > > > > >
> > > > > > > commit b904b5f
> > > > > > >> Author: Stephan Erb <s...@apache.org>
> > > > > > >> Date:   Tue Feb 14 23:33:41 2017 +0100
> > > > > > >>     Add basic test scripts for RPM and DEB packages
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Sun, Dec 10, 2017 at 1:06 PM, Stephan Erb <s...@apache.org>
> > > > wrote:
> > > > > > >
> > > > > > >> I was just trying to run the validation scripts for Debian
> > Jessie
> > > > and
> > > > > > >> those are failing with the error:
> > > > > > >>
> > > > > > >>
> > > > > > >> I1210 20:48:36.172399  7371 fetcher.cpp:283] Fetching directly
> > > into
> > > > > the
> > > > > > >> sandbox directory
> > > > > > >> I1210 20:48:36.172417  7371 fetcher.cpp:220] Fetching URI ''
> > > > > > >> Failed to fetch '': A relative path was passed for the
> resource
> > > but
> > > > > the
> > > > > > >> Mesos framework home was not specified. Please either provide
> > this
> > > > > > >> config option or avoid using a relative path
> > > > > > >>
> > > > > > >> End fetcher log for container 48b4029a-231d-441a-98a6-
> > > 8c6538fe0efa
> > > > > > >> E1210 20:48:36.220979  5590 fetcher.cpp:558] Failed to run
> > mesos-
> > > > > > >> fetcher: Failed to fetch all URIs for container
> > > '48b4029a-231d-441a-
> > > > > > >> 98a6-8c6538fe0efa' with exit status: 256
> > > > > > >> E1210 20:48:36.221174  5590 slave.cpp:4650] Container
> > > > '48b4029a-231d-
> > > > > > >> 441a-98a6-8c6538fe0efa' for executor
> > > > > 'thermos-vagrant-test-hello_world-
> > > > > > >> 0-74b87db4-0d97-4d03-a7f9-9482a1060f20' of framework
> > > 208bd6e7-5d17-
> > > > > > >> 4257-9564-71af57900310-0000 fail
> > > > > > >> ed to start: Failed to fetch all URIs for container
> > > '48b4029a-231d-
> > > > > > >> 441a-98a6-8c6538fe0efa' with exit status: 256
> > > > > > >>
> > > > > > >>
> > > > > > >> Did those tests work for you?
> > > > > > >>
> > > > > > >>
> > > > > > >> In addition, but most probably unrelated, the branch is
> missing
> > on
> > > > > http
> > > > > > >> s://github.com/apache/aurora-packaging. The ASF bot might
> have
> > > > missed
> > > > > > >> it.
> > > > > > >>
> > > > > > >>
> > > > > > >> On Fri, 2017-12-08 at 10:50 -0800, Bill Farner wrote:
> > > > > > >> > All,
> > > > > > >> >
> > > > > > >> > I propose that we accept the following artifacts as the
> > official
> > > > deb
> > > > > > >> > and
> > > > > > >> > rpm packaging for
> > > > > > >> > Apache Aurora 0.19.x:
> > > > > > >> >
> > > > > > >> > https://dl.bintray.com/bill/aurora/
> > > > > > >> >
> > > > > > >> > The Aurora deb and rpm packaging includes the following:
> > > > > > >> >
> > > > > > >> > ---
> > > > > > >> >
> > > > > > >> > The branch used to create the packaging is:
> > > > > > >> >
> > > > > https://git1-us-west.apache.org/repos/asf?p=aurora-
> > packaging.git;a=tr
> > > > > > >> > ee;hb=refs/heads/0.19.x
> > > > > > >> >
> > > > > > >> > The packages are available at:
> > > > > > >> > https://dl.bintray.com/wfarner/aurora/
> > > > > > >> >
> > > > > > >> > The GPG keys used to sign the packages are available at:
> > > > > > >> > https://dist.apache.org/repos/dist/release/aurora/KEYS
> > > > > > >> >
> > > > > > >> > Please download, verify, and test. Detailed test
> instructions
> > > are
> > > > > > >> > available
> > > > > > >> > here:
> > > > > > >> >
> > > > > https://git1-us-west.apache.org/repos/asf?p=aurora-
> > packaging.git;a=tr
> > > > > > >> > ee;f=test;hb=refs/heads/0.19.x
> > > > > > >> >
> > > > > > >> >
> > > > > > >> > The vote will close on Wed Dec 13 10:34:51 PST 2017
> > > > > > >> >
> > > > > > >> > [ ] +1 Release these as the deb and rpm packages for Apache
> > > Aurora
> > > > > > >> > 0.19.x
> > > > > > >> > [ ] +0
> > > > > > >> > [ ] -1 Do not release these artifacts because...
> > > > > > >>
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Reply via email to