+1, binding
I did encounter a unit test failure, but maintain my +1 as this test case
has been notorious flaky on macOS 10.13.3 (especially for me, apparently).
All other checks in the verification script pass.
def _run_collector_tests(collector, target, wait):
assert collector.value == 0
collector.sample()
wait()
assert collector.value == 0
f1 = make_file(TEST_AMOUNT_1, dir=target)
wait()
> assert collector.value >= TEST_AMOUNT_1.as_(Data.BYTES)
E assert 100728832 >= 104857600.0
E + where 100728832 =
<apache.thermos.monitoring.disk.DiskCollector object at 0x11138de50>.value
E + and 104857600.0 = <bound method Amount.as_ of Amount(100,
MB)>(<twitter.common.quantity.Data object at 0x11018cbd0>)
E + where <bound method Amount.as_ of Amount(100, MB)> =
Amount(100, MB).as_
E + and <twitter.common.quantity.Data object at 0x11018cbd0> =
Data.BYTES
src/test/python/apache/thermos/monitoring/test_disk.py:44: AssertionError
On Wed, Feb 7, 2018 at 3:41 PM, Renan DelValle <renanidelva...@gmail.com>
wrote:
> This point release fixes the list arg parsing regression experienced due to
> switching to JCommander so that we may release binary packages for 0.19.x
>
> Kicking off the voting with a +1 from me.
>
> Validated with ./build-support/release/verify-release-candidate 0.19.1-rc0
>
> On Wed, Feb 7, 2018 at 3:37 PM, Renan DelValle <renanidelva...@gmail.com>
> wrote:
>
> > All,
> >
> > I propose that we accept the following release candidate as the official
> > Apache Aurora 0.19.1 release.
> >
> > Aurora 0.19.1-rc0 includes the following:
> > ---
> > The RELEASE NOTES for the release are available at:
> > https://git-wip-us.apache.org/repos/asf?p=aurora.git&f=RELEA
> > SE-NOTES.md&hb=rel/0.19.1-rc0
> >
> > The CHANGELOG for the release is available at:
> > https://git-wip-us.apache.org/repos/asf?p=aurora.git&f=CHANG
> > ELOG&hb=rel/0.19.1-rc0
> >
> > The tag used to create the release candidate is:
> > https://git-wip-us.apache.org/repos/asf?p=aurora.git;a=short
> > log;h=refs/tags/rel/0.19.1-rc0
> >
> > The release candidate is available at:
> > https://dist.apache.org/repos/dist/dev/aurora/0.19.1-rc0/apa
> > che-aurora-0.19.1-rc0.tar.gz
> >
> > The MD5 checksum of the release candidate can be found at:
> > https://dist.apache.org/repos/dist/dev/aurora/0.19.1-rc0/apa
> > che-aurora-0.19.1-rc0.tar.gz.md5
> >
> > The signature of the release candidate can be found at:
> > https://dist.apache.org/repos/dist/dev/aurora/0.19.1-rc0/apa
> > che-aurora-0.19.1-rc0.tar.gz.asc
> >
> > The GPG key used to sign the release are available at:
> > https://dist.apache.org/repos/dist/dev/aurora/KEYS
> >
> > Please download, verify, and test.
> >
> > The vote will close on Sat Feb 10 14:00:33 PST 2018
> >
> > [ ] +1 Release this as Apache Aurora 0.19.1
> > [ ] +0
> > [ ] -1 Do not release this as Apache Aurora 0.19.1 because...
> >
>
