> On Dec. 16, 2013, 8:10 p.m., Bill Farner wrote: > > Now that we've straightened out the purpose, i'm wondering if it makes > > sense to approach from the direction of adding a half-baked page. Would it > > be more appropriate to wait until the thrift API support is there so we can > > populate this page?
Sure we can wait. Sent this small review out to make sure I am on the right track implementation wise and also to keep the code reviews small. Will send out the next reviews on this thread then. - Suman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16195/#review30474 ----------------------------------------------------------- On Dec. 16, 2013, 6:37 p.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16195/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 6:37 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Added a home page with basic header for the new UI. > > Updated ServletModule accordingly. > > > Diffs > ----- > > src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java > 2922f35df683ef3673c5fd83e391d7aba95415a7 > src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html > PRE-CREATION > > Diff: https://reviews.apache.org/r/16195/diff/ > > > Testing > ------- > > Tested using local isolated scheduler. > > gradle clean build. > > > Thanks, > > Suman Karumuri > >
