> On Dec. 14, 2013, 1:52 a.m., Bill Farner wrote: > > It would be really nice to see the third-party sources placed in a > > directory that makes the ownership blindingly obvious (and sheds our > > namespacing). For example, third_party/javascript would be awesome. This > > will require some gradle spelunking, but i'm confident it's possible.
Will add a third_party/javascript dir and send out another review. - Suman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16192/#review30396 ----------------------------------------------------------- On Dec. 14, 2013, 1:12 a.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16192/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2013, 1:12 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Now installing JQuery and bootstrap from bower. > > Addded docs on managing bower dependencies and installing bower. > > Added docs on running the isolated scheduler script. > > Added a manifest to scheduler jar target in build.gradle, so the generated > jar can be used in java -jar option. > > > Diffs > ----- > > build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9 > docs/developing-aurora-scheduler.md > 1beafdc6466d2f5bdd0f09ea253bc8963e552f03 > src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java > 2922f35df683ef3673c5fd83e391d7aba95415a7 > > src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/.bower.json > PRE-CREATION > > src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/README.md > PRE-CREATION > > src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/bower.json > PRE-CREATION > > src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.css > PRE-CREATION > > src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.min.css > PRE-CREATION > > src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.css > PRE-CREATION > > src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.min.css > PRE-CREATION > > src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings-white.png > PRE-CREATION > > src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings.png > PRE-CREATION > > src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.js > PRE-CREATION > > src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.min.js > PRE-CREATION > > src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/.bower.json > PRE-CREATION > > src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/component.json > PRE-CREATION > > src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/jquery.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/16192/diff/ > > > Testing > ------- > > Tested the UI using the isolated scheduler. > > gradle clean build. > > > Thanks, > > Suman Karumuri > >
