> On Dec. 24, 2013, 1:13 a.m., Jonathan Boulle wrote: > > src/main/python/twitter/aurora/client/api/updater.py, line 170 > > <https://reviews.apache.org/r/16311/diff/2/?file=402814#file402814line170> > > > > camelcase, ye heathen
Duh.. Thanks, fixed. > On Dec. 24, 2013, 1:13 a.m., Jonathan Boulle wrote: > > src/main/python/twitter/aurora/client/api/updater.py, line 180 > > <https://reviews.apache.org/r/16311/diff/2/?file=402814#file402814line180> > > > > camelcase Fixed. > On Dec. 24, 2013, 1:13 a.m., Jonathan Boulle wrote: > > src/main/python/twitter/aurora/client/api/updater.py, lines 172-174 > > <https://reviews.apache.org/r/16311/diff/2/?file=402814#file402814line172> > > > > what if this passes a list to self._convertDict? Not sure I understand. This function pair is designed to recursively pass control from _convert_dict to _convert_list and back as many times as the nesting requires. What's your concern here? - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16311/#review30845 ----------------------------------------------------------- On Dec. 23, 2013, 6:51 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16311/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2013, 6:51 p.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Repository: aurora > > > Description > ------- > > Hopefully fixing the thrift object diff once an for all. Instead of sorting > __dict__ that proved to not cover all cases, converting thrift to sorted > tuples via json serialization. > > > Diffs > ----- > > src/main/python/twitter/aurora/client/api/updater.py > 6e8e8a9fdfcf63a8fe0558d5ac36298601fd0552 > src/test/python/twitter/aurora/client/api/test_updater.py > ae4de2b57be16f8daf030210abda1ba05f9f30a0 > > Diff: https://reviews.apache.org/r/16311/diff/ > > > Testing > ------- > > ./pants src/test/python/twitter/aurora/client/api:updater > > > Thanks, > > Maxim Khutornenko > >
