----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16615/#review31178 -----------------------------------------------------------
a couple nits docs/configurationtutorial.md <https://reviews.apache.org/r/16615/#comment59572> This should be constraints = [Constraint(order=['foo', 'bar'])] There is a function defined in schema_helpers.py called order() that will take order('foo', 'bar', 'baz') and convert it into [Constraint(order=['foo', 'bar', 'baz'])]. order() will accept strings indicating process names ('foo', 'bar') or the processes themselves, e.g. foo=Process(name='foo', ...), bar=Process(name='bar', ...), constraints=order(foo, bar) docs/configurationtutorial.md <https://reviews.apache.org/r/16615/#comment59573> This is actually not true -- we do not implement the Mustache specification, we just use mustaches {{}} for indicating which variables should be bound. - Brian Wickman On Jan. 3, 2014, 7:19 p.m., Tom Galloway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16615/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2014, 7:19 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > Client command hooks doc > > > Resource isolation doc > > > Configuration tutorial > > > User guide doc > > > Configuration file reference > > > Tutorial doc > > > Client commands doc > > > User doc overview > > > Doc images > > > Adding initial image in images directory > > > Diffs > ----- > > docs/README.md PRE-CREATION > docs/clientcommands.md PRE-CREATION > docs/configurationreference.md PRE-CREATION > docs/configurationtutorial.md PRE-CREATION > docs/hooks.md PRE-CREATION > docs/images/CPUavailability.png PRE-CREATION > docs/images/HelloWorldJob.png PRE-CREATION > docs/images/RoleJobs.png PRE-CREATION > docs/images/ScheduledJobs.png PRE-CREATION > docs/images/TaskBreakdown.png PRE-CREATION > docs/images/aurora_hierarchy.png PRE-CREATION > docs/images/killedtask.png PRE-CREATION > docs/images/lifeofatask.png PRE-CREATION > docs/images/runningtask.png PRE-CREATION > docs/images/stderr.png PRE-CREATION > docs/images/stdout.png PRE-CREATION > docs/resourceisolation.md PRE-CREATION > docs/tutorial.md PRE-CREATION > docs/userguide.md PRE-CREATION > > Diff: https://reviews.apache.org/r/16615/diff/ > > > Testing > ------- > > > Thanks, > > Tom Galloway > >
