Berin Loritsch wrote:
Stephen McConnell wrote:
Having problems building the dist target for logkit:
1. javadoc errors due to the fact that the compat sources are not included in the target
It doesn't prevent you from building the dist.
It means that te documentation provided with the release does not include any of the depricated classes.
2. an error generating the announcement target
You need BSF.jar and Rhino.jar along with and XML parser and an
XSLT processor (i.e. Xerces/Xalan).
So in principal this could be updated in the build with a conditional if everything present then do announcement target otherwise skip it - bottom line it does not effect the release so I'm not too bugged by this point.
3. javadoc warning under a 1.4 build because of a ?? in a method description
Again, it does not prevent us from building the dist.
True - but is this a satisfactory level of quality for a distribution? If this was the only issue - I would pass - but I happen to think that the missing javadoc and manifest issues are sufficient to require a RC7.
Also, (4) no manifest is defined. I've fixed 1,3 and 4 but I'm somewhat stumped on (2).
Include the proper libraries and we should be good.
You are obviously not leveraging extension management. Non-inclusion of a manifest detailing an extension name, version and implementation version means that users *must* declare the jar in a classpath and cannot leverage extension mechanisms in containers such a Tomcat, Merlin, Phoenix, etc. These declarations are included across-the-board in the framework, excalibur, sandbox, and cornerstone jars. Getting this in place in LogKit is fixing an oversight that is well and truly overdue.
Pending resolution of (2). Due to the fact that there is a RC6 in evaluation/vote - I didn't want to commit these changes without checking first. So, does anyone have any objections to me updating the build to include the manifest declaration and javadoc fix?
Is this something that would prevent LogKit from working properly?
It will not prevent logkit from working properly but it does complicate matters if a user is building jar files that declare extension depedecies on other jar files. Without the manifest logkit cannot participate as a shareable extension and must be explicity included in a classpath.
Let's wait until we have a release.
Lets' do a release that we don't need to update. Cheers, Steve. -- Stephen J. McConnell mailto:[EMAIL PROTECTED] http://www.osm.net --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
