I changed the AbstractDualLogEnabled on friday; it now tests when the "Loggable" Logger is set, if the "LogEnabled" is already set; and only if that was not set previously, the wrapper is used. I guess this should fix the problem as well; if not, the change should not do any harm.
Carsten > -----Original Message----- > From: news [mailto:[EMAIL PROTECTED] Behalf Of Leo Simons > Sent: Monday, June 30, 2003 10:24 AM > To: [EMAIL PROTECTED] > Subject: Re: SitemapSource calls Pipeline twice, Logging issue in Avalon > > > Anton Tagunov wrote: > > vsbisc> 2. org.apache.avalon.excalibur.component.DefaultComponentFactory > > vsbisc> Method newInstance first checks if a Component > implements "LogEnabled" and > > vsbisc> after this it checks for "Loggable". The problem is, if > a Component impl. > > vsbisc> AbstractDualLogEnabled like ExcaliburComponentSelector > the "setLogger" > > vsbisc> method of AbstractDualLogEnabled impl. overwrites the > prev. set Logger > > > > Have I fixed this? :-) > > > > - if( component instanceof Loggable ) > > + else if( component instanceof Loggable ) > > that's along the line of my expectation of correct behaviour. But it > might break existing code that depends on receiving both? > > - Leo > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
