mcconnell 2003/07/12 14:12:06 Modified: meta/api/src/java/org/apache/avalon/meta/info ReferenceDescriptor.java meta/api/src/test/org/apache/avalon/meta/info/test ReferenceDescriptorTestCase.java Log: Add ReferenceDescriptor compliance test. Revision Changes Path 1.9 +7 -1 avalon-sandbox/meta/api/src/java/org/apache/avalon/meta/info/ReferenceDescriptor.java Index: ReferenceDescriptor.java =================================================================== RCS file: /home/cvs/avalon-sandbox/meta/api/src/java/org/apache/avalon/meta/info/ReferenceDescriptor.java,v retrieving revision 1.8 retrieving revision 1.9 diff -u -r1.8 -r1.9 --- ReferenceDescriptor.java 12 Jul 2003 16:12:38 -0000 1.8 +++ ReferenceDescriptor.java 12 Jul 2003 21:12:06 -0000 1.9 @@ -177,6 +177,12 @@ { boolean match = false; + // + // TODO: check validity of the following - this is + // assuming the equality is equivalent to compliance + // which is not true + // + if ( other instanceof ReferenceDescriptor ) { match = ( (ReferenceDescriptor) other ).matches( this ); 1.2 +9 -0 avalon-sandbox/meta/api/src/test/org/apache/avalon/meta/info/test/ReferenceDescriptorTestCase.java Index: ReferenceDescriptorTestCase.java =================================================================== RCS file: /home/cvs/avalon-sandbox/meta/api/src/test/org/apache/avalon/meta/info/test/ReferenceDescriptorTestCase.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- ReferenceDescriptorTestCase.java 11 Jul 2003 19:27:28 -0000 1.1 +++ ReferenceDescriptorTestCase.java 12 Jul 2003 21:12:06 -0000 1.2 @@ -110,6 +110,15 @@ assertEquals(version, ref.getVersion()); } + public void testCompliance() + { + ReferenceDescriptor ref = new ReferenceDescriptor( m_classname, m_version ); + ReferenceDescriptor any = new ReferenceDescriptor( m_classname, new Version( -1, 0, 0 ) ); + + assertTrue( "anything matches explicit", any.matches( ref ) ); + assertFalse( "explicit does not match anything", ref.matches( any ) ); + } + public void testSerialization() throws IOException, ClassNotFoundException { ReferenceDescriptor entry = new ReferenceDescriptor( m_classname, m_version );
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]