[
https://issues.apache.org/jira/browse/AVRO-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877848#action_12877848
]
Doug Cutting commented on AVRO-573:
-----------------------------------
We probably need a match=ERROR in HandshakeResponse. Arguably it's a
back-compatible change, since it will cause applications to fail with an
enum-out-of-bounds error rather than some other error.
Here's a proposal:
- move the handshake to it's own try block. in case of error, write a
match=ERROR response
- add mark() & reset() methods to ByteBufferOutputStream(), to save & restore
its position
- call bbo.mark() after the handshake response is written
- call bbo.reset() in the catch clause before writing system error
How's that sound?
> Need to include Handshake Response when handling a system error on the Java
> server side
> ---------------------------------------------------------------------------------------
>
> Key: AVRO-573
> URL: https://issues.apache.org/jira/browse/AVRO-573
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Jeff Hammerbacher
> Fix For: 1.4.0
>
>
> System error is not handling everything right now. Details in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
