[ 
https://issues.apache.org/jira/browse/AVRO-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890981#action_12890981
 ] 

Jeff Hammerbacher commented on AVRO-573:
----------------------------------------

Doug,

The problem I turned up was in ipc/Responder.java, and was described by:

bq. Inside of the catch block where we handle system errors, however, I believe 
we're doing something bad: we're creating a new ByteBufferOutputStream bbo, 
which blows away our old bbo. Our old bbo, however, had some useful stuff in it 
that we've failed to recreate: the HandshakeResponse. Thus any client trying to 
read a system error appears SOL

I did a quick glance at the patch and don't see any change to 
ipc/Responder.java, so I'm not sure if the new tests (which are great!) are 
hitting the same problem I'm seeing above. I'll get out my test environment and 
see what I find.

Thanks,
Jeff

> Need to include Handshake Response when handling a system error on the Java 
> server side
> ---------------------------------------------------------------------------------------
>
>                 Key: AVRO-573
>                 URL: https://issues.apache.org/jira/browse/AVRO-573
>             Project: Avro
>          Issue Type: Bug
>          Components: java, spec
>            Reporter: Jeff Hammerbacher
>            Assignee: Doug Cutting
>             Fix For: 1.4.0
>
>         Attachments: AVRO-573.patch
>
>
> System error is not handling everything right now. Details in the comments.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to