[
https://issues.apache.org/jira/browse/AVRO-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910755#action_12910755
]
Doug Cutting commented on AVRO-668:
-----------------------------------
Did you mean to use 'Utf8.class.equals(charSequence.getClass())'? I think
'charSequence instanceof Utf8' reads much better, and, as we discussed in
AVRO-667, the performance improvement is perhaps not significant and this might
be risky if Utf8 is not final.
(I wonder whether HotSpot doesn't already optimize instanceof for classes with
no subclasses yet defined to be ==. It could, couldn't it?)
Did we also want to update GenericDatumWriter#writeString()? Maybe not...
Other than that, +1
> Java: Streamline writing of Strings for Encoders and GenericDatumWriter
> -----------------------------------------------------------------------
>
> Key: AVRO-668
> URL: https://issues.apache.org/jira/browse/AVRO-668
> Project: Avro
> Issue Type: Improvement
> Reporter: Scott Carey
> Assignee: Scott Carey
> Fix For: 1.4.1
>
> Attachments: AVRO-668.patch, AVRO-668.patch, AVRO-668.patch
>
>
> We can streamline writing of strings to minimize object creation during
> writes.
> We can avoid converting a String into Utf8 for Json output, and for Binary
> output we can avoid a Utf8 (but still create a byte[]).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
