[
https://issues.apache.org/jira/browse/AVRO-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976896#action_12976896
]
Doug Cutting commented on AVRO-722:
-----------------------------------
This reverts a change that Patrick Wendell made in AVRO-595 when adding RPC
tracing. I'm not sure why Patrick made that change there: perhaps it was
essential but perhaps it was not. Unfortunately the trace tests are currently
disabled in pom.xml, since they intermittently fail for reasons no one has yet
debugged.
I re-enabled the trace tests in pom.xml and ran tests on unpatched trunk and
they passed. Then I applied this patch and ran tests again and trace tests
failed three times in a row. I reverted the patch and the trace tests then
passed again. So superficially it appears that this patch breaks RPC tracing.
It would be nice to re-enable the trace tests by default. I think the problems
are/were mostly caused by the use of fixed port numbers. In four runs they
pass every time for me now.
> IPC Request Metadata written for transmission before processing by plugins
> --------------------------------------------------------------------------
>
> Key: AVRO-722
> URL: https://issues.apache.org/jira/browse/AVRO-722
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.0
> Reporter: Stephen Gargan
> Priority: Minor
> Fix For: 1.5.0
>
> Attachments: rpc-plugin.patch
>
>
> There is a small issue with the processing order of request metadata in an
> IPC call. The map is written for transmission before the context is passed to
> plugins for processing and as a result any changes that client plugins make
> to the metadata will not get transferred as the empty map has already been
> written.
> Also when the response metadata is read back in it is mistakenly read into
> the context's request metadata instead of the response metadata. The attached
> patch has fixes for both of these issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
