[
https://issues.apache.org/jira/browse/AVRO-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989897#comment-12989897
]
Douglas Creager commented on AVRO-746:
--------------------------------------
I'm not married to the idea of incorporating OpenPA, it just seemed like an
expedient solution. We could easily create our own refcount.h header, that
contained static inline definitions like OpenPA's does, to ensure that we can
target all of the platforms you mention.
I'll try to run some tests to compare single-threaded performance. I don't
think it's a big hit, but some data to back that up would be nice.
> Atomic reference counts
> -----------------------
>
> Key: AVRO-746
> URL: https://issues.apache.org/jira/browse/AVRO-746
> Project: Avro
> Issue Type: Bug
> Components: c
> Reporter: Douglas Creager
> Assignee: Douglas Creager
> Attachments: 0001-Atomic-reference-counts.patch, fixed-make-dist.patch
>
>
> In one of my projects that uses Avro, I pass avro_datum_t instances between
> threads, using the reference count mechanism to make sure that they're not
> freed while any thread still has a reference to them. I was getting some
> spurious segfaults, which were caused by the fact that the reference counts
> aren't updated atomically. I've created a patch that implements atomic
> reference counts, using the [OpenPA
> library|http://trac.mcs.anl.gov/projects/openpa/] to provide the atomic
> operations themselves. (That library is MIT licensed, so it can be included
> in the source tree.)
> Note that only avro_XXX_incref and avro_XXX_decref are thread-safe as a
> result of this patch. For all of the other library functions, the caller is
> still responsible for ensuring thread safety.
> The patch makes sure that the OpenPA code works in both the old autotools
> build and the newer CMake build.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
