[ 
https://issues.apache.org/jira/browse/AVRO-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996130#comment-12996130
 ] 

Doug Cutting commented on AVRO-755:
-----------------------------------

I doubt many (if any) folks implement their own Responders, so changing this 
API is unlikely to break anyone, but still, it might be hard to do 
back-compatibly.

To fix this, I think we need to:
 - add a remote schema parameter to Responder#readRequest()
 - change GenericResponder to use this when reading the request;
 - change SpecificResponder to extend GenericResponder
   -- inherit its readRequest implementation
   -- in respond(), construct the parameter array from the GenericRecord request
 - add some tests

> Responder.readRequest only has remote schema as argument, not local schema
> --------------------------------------------------------------------------
>
>                 Key: AVRO-755
>                 URL: https://issues.apache.org/jira/browse/AVRO-755
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.4.1
>            Reporter: Xiaolu Ye
>
> readRequest in Responder only has remote schema as argument. This works fine 
> when local and remote schame are the same. But if remote and local schema are 
> different, but compatible, the readRequest has no access to local schema when 
> creating DatumReader to read the request

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to