[ 
https://issues.apache.org/jira/browse/AVRO-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeremy Lewi updated AVRO-570:
-----------------------------

    Attachment: AVRO-570.patch

Doug, I appreciate your careful review, and I've attempted to fix all the 
issues you pointed out in this patch.

TRANSPROTO has been renamed to PROTOCOL and I addeded some javadoc. The code 
also uses "switch" instead of "if-else" blocks to process the protocol.

I would argue that currently we need a NONE value for PROTOCOL because there is 
no intelligent default. From my limited understanding of protocols, http is a 
very inefficient protocol for tethered jobs. So HTTP probably isn't a good 
default. On the other hand, SASL isn't supported in python and python is the 
only language other than java supporting tethered jobs so SASL probably isn't a 
good choice either.

I renamed the python test target "test-570" to "test-tether" so that we don't 
reference a jira. Is this acceptable?

I tried to address all of the cosmetic issues Doug pointed out. It does look 
like SVN is doing some white space only changes but I think this might be 
because I changed some tabs to spaces. 

I'd also like to call the reviewer's attention to the fact that I've changed 
the hadoop version for the dependency in the POM. (See AVRO-852).

> python implementation of mapreduce connector
> --------------------------------------------
>
>                 Key: AVRO-570
>                 URL: https://issues.apache.org/jira/browse/AVRO-570
>             Project: Avro
>          Issue Type: New Feature
>          Components: python
>    Affects Versions: 1.6.0
>            Reporter: Doug Cutting
>            Assignee: Jeremy Lewi
>            Priority: Critical
>              Labels: hadoop
>         Attachments: AVRO-570.patch, AVRO-570.patch, AVRO-570.patch, 
> AVRO-570.patch
>
>
> AVRO-512 defines protocols for implementing mapreduce tasks.  It would be 
> good to have a Python implementation of this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to